Skip to content

Simplify snapit message#6329

Merged
gonzaloriestra merged 2 commits intomainfrom
simplify-snapit
Aug 28, 2025
Merged

Simplify snapit message#6329
gonzaloriestra merged 2 commits intomainfrom
simplify-snapit

Conversation

@gonzaloriestra
Copy link
Contributor

@gonzaloriestra gonzaloriestra commented Aug 27, 2025 •
edited
Loading

WHY are these changes introduced?

We want to simplify the snapit message and always include the shopify registry

WHAT is this pull request doing?

Updates the snapit workflow to use this branch where I added two new params:

  • package_manager: to force NPM here
  • shopify_registry: to add --@shopify:registry=https://registry.npmjs.org to the command by default

How to test your changes?

Merge and test from another PR

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@gonzaloriestra
Copy link
Contributor Author

gonzaloriestra commented Aug 27, 2025

/snapit

@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2025

🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

pnpm i -g @shopify/cli@0.0.0-snapshot-20250827150542

Tip

If you get an ETARGET error, install it with NPM and the flag --@shopify:registry=https://registry.npmjs.org

Caution

After installing, validate the version by running just shopify in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2025 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟡 Statements
78.61% (+0.03% 🔼)
 13503/17178
🟡 Branches
72.6% (+0.08% 🔼)
 6575/9057
🟡 Functions
78.83% (+0.01% 🔼)
 3511/4454
🟡 Lines
78.97% (+0.03% 🔼)
 12764/16163

Test suite run success

3236 tests passing in 1354 suites.

Report generated by 🧪jest coverage report action from 7fb3e46

@gonzaloriestra
Copy link
Contributor Author

gonzaloriestra commented Aug 27, 2025

/snapit

@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2025

🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

pnpm i -g @shopify/cli@0.0.0-snapshot-20250827151222

Tip

If you get an ETARGET error, install it with NPM and the flag --@shopify:registry=https://registry.npmjs.org

Caution

After installing, validate the version by running just shopify in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

@gonzaloriestra gonzaloriestra marked this pull request as ready for review August 27, 2025 15:18
@gonzaloriestra gonzaloriestra requested a review from a team as a code owner August 27, 2025 15:18
isaacroldan
isaacroldan approved these changes Aug 27, 2025
View reviewed changes
Copy link
Contributor

@isaacroldan isaacroldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try

@gonzaloriestra gonzaloriestra added this pull request to the merge queue Aug 28, 2025
Merged via the queue into main with commit f7a5f18 Aug 28, 2025
2 checks passed
@gonzaloriestra gonzaloriestra deleted the simplify-snapit branch August 28, 2025 07:41
@gonzaloriestra gonzaloriestra mentioned this pull request Aug 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isaacroldan isaacroldan isaacroldan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gonzaloriestra @isaacroldan